Improve KLayout-based SPICE handling to support Calibre LVS with generic devices #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, `NoCommentReader` is changed to Calibre output supported reader
There was a problem hiding this comment.
Hey @nikosavola - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -32,28 +33,26 @@ def spice_netlist(tmpdir_factory) -> str: | |||
| return netlist_path | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("fully_connected", [True, False]) | |||
| @pytest.mark.skip( | |||
There was a problem hiding this comment.
suggestion (testing): Consider updating test cases to reflect new implementation details.
The test is currently skipped due to the change in implementation that focuses on detected devices. It might be beneficial to update or add new test cases that align with the current implementation, especially considering the handling of generic devices and parameters in CalibreSpiceReader.
| spice_reader_instance = None | ||
| match Path(filepath).suffix: | ||
| case ".l2n" | ".txt": | ||
| l2n = kdb.LayoutToNetlist() |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Extract duplicate code into function (
extract-duplicate-method) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
1a56d78 to
135162c
Compare
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plot_nets