Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump max gdsfactory version to accept latest one #265

Closed
wants to merge 1 commit into from
Closed

Bump max gdsfactory version to accept latest one #265

wants to merge 1 commit into from

Conversation

nikosavola
Copy link
Member

@nikosavola nikosavola commented Dec 4, 2023 •
edited
Loading

I think this is causing problems when trying to install latest gdsfactory and gplugins. Gdsfactory will have to resort to an older version.

@nikosavola nikosavola added the dependencies Pull requests that update a dependency file label Dec 4, 2023
@nikosavola nikosavola requested a review from joamatab December 4, 2023 19:21
@nikosavola nikosavola self-assigned this Dec 4, 2023
@joamatab joamatab mentioned this pull request Dec 4, 2023
Merged
@joamatab
Copy link
Contributor

joamatab commented Dec 4, 2023

I also fixed the tests here

#266

@joamatab joamatab closed this Dec 4, 2023
@nikosavola nikosavola deleted the bump-max-gdsfactory-version branch May 30, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamatab joamatab Awaiting requested review from joamatab

Assignees

@nikosavola nikosavola

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikosavola @joamatab