Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow complex materials and rely on tidy3d hash function #261

Merged
merged 1 commit into from
Dec 2, 2023
Merged

allow complex materials and rely on tidy3d hash function #261

merged 1 commit into from
Dec 2, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Dec 2, 2023

  • allow complex materials by using the hash of tidy3d modeler
  • use tidy3d hash

@tyler-flex
@yaugenst
@heitzmann

@joamatab joamatab requested a review from yaugenst December 2, 2023 00:09
yaugenst
yaugenst approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@yaugenst yaugenst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joamatab joamatab merged commit de27536 into main Dec 2, 2023
@joamatab joamatab deleted the allow_complex_materials branch December 2, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaugenst yaugenst yaugenst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joamatab @yaugenst