-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate gmsh plugin #159
Conversation
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 40.20% 39.13% -1.08%
==========================================
Files 170 174 +4
Lines 10550 10459 -91
==========================================
- Hits 4242 4093 -149
- Misses 6308 6366 +58
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
looks great Simon tests are still failing for the docs https://github.com/gdsfactory/gplugins/actions/runs/6252637081/job/16976318317 |
Fixed! |
Thank you Simon!
…On Wed, Sep 20, 2023 at 1:02 PM Simon Bilodeau ***@***.***> wrote:
looks great Simon
tests are still failing for the docs
https://github.com/gdsfactory/gplugins/actions/runs/6252637081/job/16976318317
Fixed!
—
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCOEKRDMD2V6P5O6RNCBBDX3NDVDANCNFSM6AAAAAA5AKSHBM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@mdecea this was the PR |
Remove all legacy meshing code, rely entirely on meshwell
First step towards making the plugin compliant with the new interface #142