Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate gmsh plugin #159

Merged
merged 10 commits into from
Sep 20, 2023
Merged

Consolidate gmsh plugin #159

merged 10 commits into from
Sep 20, 2023

Conversation

simbilod
Copy link
Collaborator

Remove all legacy meshing code, rely entirely on meshwell

First step towards making the plugin compliant with the new interface #142

@simbilod simbilod marked this pull request as draft September 20, 2023 18:15
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #159 (591e311) into main (9a473b6) will decrease coverage by 1.08%.
Report is 24 commits behind head on main.
The diff coverage is 64.26%.

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   40.20%   39.13%   -1.08%     
==========================================
  Files         170      174       +4     
  Lines       10550    10459      -91     
==========================================
- Hits         4242     4093     -149     
- Misses       6308     6366      +58     
Files Changed Coverage Δ
gplugins/common/utils/add_simulation_markers.py 31.70% <ø> (ø)
gplugins/common/utils/async_helpers.py 26.66% <ø> (ø)
gplugins/common/utils/cache.py 21.42% <ø> (ø)
gplugins/common/utils/convert_sparameters.py 23.63% <ø> (ø)
gplugins/common/utils/disable_print.py 100.00% <ø> (ø)
gplugins/common/utils/get_effective_indices.py 87.17% <ø> (ø)
gplugins/common/utils/get_sparameters_path.py 84.78% <ø> (ø)
gplugins/common/utils/plot.py 21.05% <ø> (ø)
gplugins/common/utils/plot_csv.py 28.57% <ø> (ø)
gplugins/common/utils/port_symmetries.py 27.27% <ø> (ø)
... and 63 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@simbilod simbilod marked this pull request as ready for review September 20, 2023 18:28
@joamatab
Copy link
Contributor

looks great Simon

tests are still failing for the docs

https://github.com/gdsfactory/gplugins/actions/runs/6252637081/job/16976318317

@simbilod
Copy link
Collaborator Author

looks great Simon

tests are still failing for the docs

https://github.com/gdsfactory/gplugins/actions/runs/6252637081/job/16976318317

Fixed!

@joamatab joamatab merged commit 0ce7b30 into gdsfactory:main Sep 20, 2023
@joamatab
Copy link
Contributor

joamatab commented Sep 20, 2023 via email

@simbilod
Copy link
Collaborator Author

simbilod commented Oct 5, 2023

@mdecea this was the PR

@simbilod simbilod deleted the fix_uz_meshing branch October 11, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants