add via_yoffset to via_chain #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @joamatab - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -22,6 +22,7 @@ def via_chain( | |||
| via_min_enclosure: float = 1.0, | |||
| min_metal_spacing: float = 1.0, | |||
| via_xoffset: float = 0.0, | |||
| via_yoffset: float = 0.0, | |||
There was a problem hiding this comment.
suggestion (code_clarification): Consider documenting the new parameter 'via_yoffset'.
Adding a brief description of 'via_yoffset' in the function's docstring would help maintainers and users understand its purpose and usage.
Suggested change
| via_yoffset: float = 0.0, | |
| via_yoffset: float = 0.0, | |
| """Via chain to extract via resistance. | |
| Args: | |
| via_yoffset (float): The vertical offset for the via placement from a reference point. | |
| """ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2678 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 366 366
Lines 23755 23755
Branches 3873 3873
=======================================
Hits 17052 17052
Misses 5578 5578
Partials 1125 1125 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.