Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max 100% width/height for video previewer #89

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

jo-pol
Copy link

@jo-pol jo-pol commented Nov 12, 2024

This should fix IQSS/dataverse#11014

@qqmyers
Copy link
Member

qqmyers commented Nov 12, 2024

@jo-pol - thanks - can you please make your change in the betatest dir (see https://github.com/gdcc/dataverse-previewers/blob/develop/CONTRIBUTING.md).

@jo-pol jo-pol closed this Nov 14, 2024
@jo-pol jo-pol deleted the 11014-video-size branch November 14, 2024 08:51
@jo-pol jo-pol restored the 11014-video-size branch November 14, 2024 09:25
@jo-pol jo-pol reopened this Nov 14, 2024
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll go ahead and merge.

@qqmyers qqmyers merged commit d1b7de0 into gdcc:develop Nov 14, 2024
@qqmyers
Copy link
Member

qqmyers commented Nov 18, 2024

@jo-pol - FYI - I just noticed we had an overlapping PR - #61 - that set the max width but not the max-height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Videos are sometimes too large for previewer
2 participants