Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3350: Simple fed store fixes #3358

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Gh-3350: Simple fed store fixes #3358

merged 4 commits into from
Jan 29, 2025

Conversation

p29876
Copy link
Member

@p29876 p29876 commented Jan 27, 2025

Related issue

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.08%. Comparing base (9a0de1b) to head (76ca077).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...e/operation/handler/FederatedOperationHandler.java 82.35% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3358      +/-   ##
=============================================
+ Coverage      68.06%   68.08%   +0.01%     
  Complexity      2596     2596              
=============================================
  Files            957      957              
  Lines          30684    30686       +2     
  Branches        3405     3406       +1     
=============================================
+ Hits           20886    20893       +7     
+ Misses          8314     8311       -3     
+ Partials        1484     1482       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p29876 p29876 changed the title Gh-3350 Fed store fixes Gh-3350: Simple fed store fixes Jan 27, 2025
@p29876 p29876 marked this pull request as ready for review January 27, 2025 15:14
@j69772 j69772 requested review from cn337131 and j69772 January 29, 2025 11:47
@j69772 j69772 merged commit 3ec4c9b into develop Jan 29, 2025
28 of 29 checks passed
@j69772 j69772 deleted the gh-3350-fed-store branch January 29, 2025 14:46
@cn337131 cn337131 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Feb 4, 2025
@cn337131 cn337131 modified the milestones: 2.3.2, 2.4.0 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate optimisations for federated POC
4 participants