DeleteElements to return count #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tb06904
reviewed
Jan 21, 2025
.../src/main/java/uk/gov/gchq/gaffer/accumulostore/operation/handler/DeleteElementsHandler.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3356 +/- ##
=============================================
+ Coverage 68.06% 68.08% +0.02%
Complexity 2596 2596
=============================================
Files 957 957
Lines 30674 30684 +10
Branches 3402 3405 +3
=============================================
+ Hits 20877 20892 +15
+ Misses 8313 8310 -3
+ Partials 1484 1482 -2 ☔ View full report in Codecov by Sentry. |
tb06904
approved these changes
Jan 21, 2025
p29876
approved these changes
Jan 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeleteElements will now return a count to reflect the number of elements deleted. Additional debug logging added as well to allow users to check what is deleted.
Related issue