Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3344: Change graph permissions operation in federated POC #3345

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Dec 10, 2024

Adds an operation to allow changing the graph accesses of sub graphs on the new federated store.

@tb06904 tb06904 added federated-store Specific to/touches the federated-store module feature A proposed new feature labels Dec 10, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Dec 10, 2024
@tb06904 tb06904 requested review from cn337131 and p29876 December 10, 2024 16:03
@tb06904 tb06904 linked an issue Dec 10, 2024 that may be closed by this pull request
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@tb06904
Copy link
Member Author

tb06904 commented Dec 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions 19.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Duplication is unavoidable due to the operation interface as it has similar fields to the AddGraph operation.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 16 lines in your changes missing coverage. Please review.

Project coverage is 68.07%. Comparing base (1a91fcf) to head (eeaf911).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../federated/simple/operation/ChangeGraphAccess.java 74.35% 10 Missing ⚠️
...eration/handler/misc/ChangeGraphAccessHandler.java 60.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3345      +/-   ##
=============================================
+ Coverage      68.05%   68.07%   +0.01%     
  Complexity      2596     2596              
=============================================
  Files            955      957       +2     
  Lines          30613    30671      +58     
  Branches        3393     3398       +5     
=============================================
+ Hits           20833    20878      +45     
- Misses          8300     8310      +10     
- Partials        1480     1483       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wb36499 wb36499 merged commit a900916 into develop Dec 11, 2024
29 of 30 checks passed
@wb36499 wb36499 deleted the 3344-graph-permissions-in-federated-poc branch December 11, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation to modify graph permissions in Federated POC
4 participants