Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3342: Handle different groups in View federated poc #3343

Merged

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Dec 2, 2024

Adds ability to handle groups in a View that might not be relevant to a selected sub graph.

Related issue

@tb06904 tb06904 added federated-store Specific to/touches the federated-store module feature A proposed new feature labels Dec 2, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Dec 2, 2024
@tb06904 tb06904 linked an issue Dec 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 88.40580% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.05%. Comparing base (7726ff3) to head (d0ec130).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...v/gchq/gaffer/federated/simple/FederatedUtils.java 84.00% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3343      +/-   ##
=============================================
+ Coverage      68.00%   68.05%   +0.05%     
  Complexity      2596     2596              
=============================================
  Files            954      955       +1     
  Lines          30555    30613      +58     
  Branches        3380     3393      +13     
=============================================
+ Hits           20778    20833      +55     
+ Misses          8302     8300       -2     
- Partials        1475     1480       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 4, 2024

@wb36499 wb36499 merged commit 1a91fcf into develop Dec 5, 2024
29 checks passed
@wb36499 wb36499 deleted the gh-3342-handle-different-groups-in-view-federated-poc branch December 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to handle different groups in View Federated POC
4 participants