Accessibility - Notify keyboard/screen reader user how to exit input field #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3957273
reviewed
Apr 11, 2024
| @@ -91,7 +91,7 @@ class InputWaiter { | |||
| lineWrapping: new Compartment, | |||
| fileDetailsPanel: new Compartment | |||
| }; | |||
|
|
|||
| localStorage.setItem("alerted", "no"); | |||
There was a problem hiding this comment.
Maybe best to change this to this.alerted = 'no' as opposed to using local storage.
|
Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue #1718
This PR aims to solve some of the 'limited keyboard interaction' outlined in item 2 of keyboard Navigation in the issue linked above. E.g. Keyboard trap within input field - For a non mouse user tabbing through the page it may seem as though there is a keyboard trap when you reach the input field. Pressing Escape and then tab allows you to move on to the next tab-able element, however this may not be obvious and so instructional alert has been added if a user presses tab within the input field.
Code changes:
User-facing changes:
To replicate:
Tabto input field and enter textPress
Tabagain and expect to see an alert pop up with instruction to press escapeContinue typing, press
Tabagain within the input field and expect the alert not to appear repetitivelyPress
EscapethenTabto exit the input fieldRefresh the page and repeat the above steps with a screen reader active and expect the same text that's within the alert to be announced on first tab press and not on subsequent