-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented keyboard navigation to operations menu #1724
Open
j264415
wants to merge
25
commits into
gchq:master
Choose a base branch
from
j264415:tabbing-to-side-panel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Favourites dialog box keyboard navigation
Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#1718 - Accessibility Audit for Keyboard Navigation, Screen Reader and High Zoom
As documented in this issue I am solving:
Code changes:
tabindex="0"
, enabling access to operations via theTab
key.keydown
event listener was added to operations and categories to replicate mouse functionality.User-facing changes:
Tab
key. They can then use eitherEnter
or theSpacebar
to open and close the operations panels.CTRL + Enter
to add operations to the recipe field.Enter
or theSpacebar
to open favourites dialog box.Replication for tabbing to side panel :
To replicate navigating edit favorites with keyboard:
Enter
orspacebar
to open the edit dialog box