-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Adds scrolling to description popover #170
Conversation
Thanks for taking a look at this. There are a couple of undesirable behaviours associated with it at the moment which I can't quite iron out.
|
You can't have hover and scrolling at the same time because as soon as you stop hovering over the element it disappears, and if you try scrolling when you're hovering it just scrolls the list of operations! I'm not sure what the solution to this is though. I'll fix the overflow/arrow issue shortly, however. |
I agree this is not possible without modifications to the way Bootstrap handles the hover event. There are some possible solutions here that might work: https://stackoverflow.com/questions/7703878/how-can-i-hold-twitter-bootstrap-popover-open-until-my-mouse-moves-into-it |
Right, I've fixed the arrow issue. When fixing this, I was thinking that maybe we should set the max-height to 80 or 90%, I think it looks less cramped than having it flow all the way from the top to the bottom of the screen. I've set this at 90% in the latest commit, so maybe I could get a few second opinions. In regards to the hover event issue; to use the solutions seen on SO we'd have to run it every time the list of operations updates - I'm not particularly sure how I can catch this, but the solution that I got to work best was this one. If I can figure out how to call that every time the list is redisplayed, we'll be all good on that front! |
There is a listener for |
Thanks very much for this. I've made some further modifications to fix some edge cases but I think it gives the correct behaviour now. |
Update fr.json for Dashy 1.6.3
Changes data-trigger to focus so scrolling works, sets the max height and enables scrollbar.
Fixes #137.