Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown is shown beneath the recipe item below #925

Closed
dunielpls opened this issue Dec 14, 2019 · 3 comments
Closed

Dropdown is shown beneath the recipe item below #925

dunielpls opened this issue Dec 14, 2019 · 3 comments
Labels

Comments

@dunielpls
Copy link

Describe the bug
Dropdowns contained by an item in the recipe list are shown beneath the recipe item below as per the screenshot.

To Reproduce

  1. Add "XOR" to recipe.
  2. Add any item to the recipe below XOR.
  3. Open the dropdown for "Key" type (e.g. click "HEX").

Expected behaviour
Expected the dropdown to show on top of the recipe item below the dropdown's parent item.

Screenshots
image

Desktop

  • OS: Windows
  • Browser: Microsoft Edge Dev 80.0.355.1
  • CyberChef version: 9.11.14

Proposed solution
When a dropdown is activated by clicking its trigger, set the CSS attribute z-index: 1 on its parent item (#rec-list .operation) in the recipe list and remove it again when the dropdown is closed.

@dunielpls dunielpls added the bug label Dec 14, 2019
@dunielpls dunielpls changed the title Bug report: <Insert title here> Dropdown is shown beneath the recipe item below Dec 14, 2019
@n1474335
Copy link
Member

Unfortunately Microsoft Edge is not a supported browser. See here: https://github.com/gchq/CyberChef#browser-support

@dunielpls
Copy link
Author

That was a quick dismissal - the new Microsoft Edge is based on Chromium.

I also tested this in Google Chrome just now, same host machine but Chrome version 79.0.3945.79 - the issue is present also there:
Screenshot_19

@n1474335 n1474335 reopened this Dec 16, 2019
@n1474335
Copy link
Member

Apologies, we'll take a look

d98762625 pushed a commit to d98762625/CyberChef that referenced this issue Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants