Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Field quotes interpretation + help text #2193

Closed
5 tasks done
peterdesmet opened this issue Nov 13, 2023 · 5 comments
Closed
5 tasks done

Update Field quotes interpretation + help text #2193

peterdesmet opened this issue Nov 13, 2023 · 5 comments
Assignees
Milestone

Comments

@peterdesmet
Copy link
Member

peterdesmet commented Nov 13, 2023

The Field quotes help text is currently the following:

Screenshot 2023-11-13 at 12 22 59
  • Can the parser really not deal with quoted and unquoted columns and/or mixed use within a column? This is very common behaviour in CSV writers. It seems it can handle mixed situation if fieldQuotes is set to ", see below
  • The newline and carriage returns should probably not have the parenthesis, as the character is not visible.
  • Bug: Clicking any of the options does not populate the field (in contrast with Multi-value Delimiter, which does work)
  • Why not use a dropdown to set this field? This also avoids users setting double characters.
  • Why not set this field to " by default for csv files?
@peterdesmet
Copy link
Member Author

peterdesmet commented Nov 13, 2023

I uploaded this file: https://github.com/tdwg/camtrap-dp/blob/1.0/example/deployments.csv

  • It has a mixture of quoted and unquoted values across columns (all are unquoted, except for habitat and deploymentComments)
  • It has a mixture of quoted and unquoted values within the habitat and deploymentComments column (only values with , are quoted)
  • I set fieldQuotes to "

This publishes fine (IPT generates CSV that will only put quotes around values that need it), so it seems the help text is to strict.

@mike-podolskiy90 mike-podolskiy90 self-assigned this Nov 13, 2023
@mike-podolskiy90 mike-podolskiy90 added this to the 2.7.7 milestone Nov 16, 2023
@mike-podolskiy90
Copy link
Contributor

Bug: Clicking any of the options does not populate the field (in contrast with Multi-value Delimiter, which does work)

I don't see that in any test IPT

Why not use a dropdown to set this field? This also avoids users setting double characters.

Dropdown would restrict choice to those three. I think we should just leave it as is

mike-podolskiy90 added a commit that referenced this issue Nov 17, 2023
@peterdesmet
Copy link
Member Author

If not dropdown, than perhaps the field should be restricted to a single character?

@peterdesmet
Copy link
Member Author

And indeed, I cannot replicate the issue with "Clicking any of the options". Seems to work fine now

@mike-podolskiy90
Copy link
Contributor

If not dropdown, than perhaps the field should be restricted to a single character?

Don't want to add additional validation there. I think we're fine, the field will be set automatically most of the time anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants