Restrict deleteTask

gbgabiola · Oct 18, 2021 · 6ae28ed · 6ae28ed
1 parent 71a3fc8
commit 6ae28ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/tasks/tasks.controller.ts b/src/tasks/tasks.controller.ts
@@ -45,8 +45,8 @@ export class TasksController {
   }
 
   @Delete('/:id')
-  deleteTask(@Param('id') id: string): Promise<void> {
-    return this.tasksService.deleteTask(id);
+  deleteTask(@Param('id') id: string, @GetUser() user: User): Promise<void> {
+    return this.tasksService.deleteTask(id, user);
   }
 
   @Patch('/:id/status')

diff --git a/src/tasks/tasks.service.ts b/src/tasks/tasks.service.ts
@@ -19,9 +19,7 @@ export class TasksService {
   }
 
   async getTaskById(id: string, user: User): Promise<Task> {
-    const foundTask = await this.tasksRepository.findOne({
-      where: { id, user },
-    });
+    const foundTask = await this.tasksRepository.findOne({ id, user });
 
     if (!foundTask) {
       throw new NotFoundException(`Task with ID ${id} is not found.`);
@@ -33,8 +31,8 @@ export class TasksService {
     return this.tasksRepository.createTask(createTaskDto, user);
   }
 
-  async deleteTask(id: string): Promise<void> {
-    const result = await this.tasksRepository.delete(id);
+  async deleteTask(id: string, user: User): Promise<void> {
+    const result = await this.tasksRepository.delete({ id, user });
     if (result.affected === 0) {
       throw new NotFoundException(`Task with ID "${id}" is not found.`);
     }