Added Particle Emitter Python interface #999
Merged
+328
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
62 tasks
Codecov Report
@@ Coverage Diff @@
## main #999 +/- ##
==========================================
- Coverage 83.39% 83.23% -0.16%
==========================================
Files 151 152 +1
Lines 18490 18594 +104
==========================================
+ Hits 15419 15477 +58
- Misses 3071 3117 +46
Continue to review full report at Codecov.
|
azeey
requested changes
Jun 28, 2022
python/src/sdf/pyParticleEmitter.cc
Outdated
Comment on lines
23
to
26
| #include "sdf/Box.hh" | ||
| #include "sdf/Capsule.hh" | ||
| #include "sdf/Cylinder.hh" | ||
| #include "sdf/Ellipsoid.hh" |
There was a problem hiding this comment.
I don't think we need all the other headers
Suggested change
| #include "sdf/Box.hh" | |
| #include "sdf/Capsule.hh" | |
| #include "sdf/Cylinder.hh" | |
| #include "sdf/Ellipsoid.hh" | |
| #include "sdf/ParticleEmitter.hh" |
There was a problem hiding this comment.
nit: The headers below ParticleEmitter can be removed as well.
Signed-off-by: ahcorde <ahcorde@gmail.com>
azeey
approved these changes
Jun 29, 2022
python/src/sdf/pyParticleEmitter.cc
Outdated
Comment on lines
23
to
26
| #include "sdf/Box.hh" | ||
| #include "sdf/Capsule.hh" | ||
| #include "sdf/Cylinder.hh" | ||
| #include "sdf/Ellipsoid.hh" |
There was a problem hiding this comment.
nit: The headers below ParticleEmitter can be removed as well.
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
This PR is part of this meta ticket #931
Summary
Added Particle Emitter Python interface
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.