Add Element::FindElement as an alternative to Element::GetElement #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Element::GetElement` may create a child element if it doesn't exist. This makes it a non-const function. Instead of changing this behavior, a new function `Element::FindElement` is added that returns a nullptr if the child element is not found instead of creating a new element. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
chapulina
approved these changes
Jul 9, 2021
src/Element_TEST.cc
Outdated
| @@ -825,6 +825,25 @@ TEST(Element, GetNextElementMultiple) | |||
| ASSERT_EQ(child2->GetNextElement(""), nullptr); | |||
| } | |||
|
|
|||
| ///////////////////////////////////////////////// | |||
| /// Helper function to add child elements without having to create descriptions | |||
| sdf::ElementPtr AddChildElement(sdf::ElementPtr _parent, | |||
There was a problem hiding this comment.
Nit: we usually use camelCase for free functions
There was a problem hiding this comment.
Updated in d519304. I'm never sure what to do about free functions and static functions because I think we diverge from the google style guide on this.
There was a problem hiding this comment.
Yeah we don't have this documented anywhere, it's one of those things that we need to document
8 tasks
jennuine
pushed a commit
that referenced
this pull request
Jul 29, 2021
`Element::GetElement` may create a child element if it doesn't exist. This makes it a non-const function. Instead of changing this behavior, a new function `Element::FindElement` is added that returns a nullptr if the child element is not found instead of creating a new element. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #188
Summary
Element::GetElementmay create a child element if it doesn't exist.This makes it a non-const function. Instead of changing this behavior, a
new function
Element::FindElementis added that returns anullptrifthe child element is not found instead of creating a new element.
Test it
Run test
UNIT_Element_TEST.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge