Disable ign tests on Windows (sdf10) #456
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
3a2583b to
592604d
Compare
cmake/SearchForStuff.cmake
Outdated
| # Find ignition cmake2 | ||
| # Only for using the testing macros, not really | ||
| # being use to configure the whole project | ||
| find_package(ignition-cmake2 2.3 REQUIRED) |
There was a problem hiding this comment.
How about checking if (IGNITION-TOOLS_BINARY_DIRS)?
There was a problem hiding this comment.
I don't think that is useful because we often install ign-tools in windows workspaces. I think we want the macros available in all cases, so I don't think we should conditionally find this
Codecov Report
@@ Coverage Diff @@
## sdf10 #456 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 61 61
Lines 9365 9365
=======================================
Hits 8200 8200
Misses 1165 1165 Continue to review full report at Codecov.
|
cmake/SearchForStuff.cmake
Outdated
| # Find ignition cmake2 | ||
| # Only for using the testing macros, not really | ||
| # being use to configure the whole project | ||
| find_package(ignition-cmake2 2.3 REQUIRED) |
There was a problem hiding this comment.
does this need to be called before finding ignition-math6? it's a dependency of ignition-math6, so I'm not sure if an old version would be improperly cached
cmake/SearchForStuff.cmake
Outdated
| # Find ignition cmake2 | ||
| # Only for using the testing macros, not really | ||
| # being use to configure the whole project | ||
| find_package(ignition-cmake2 2.3 REQUIRED) |
There was a problem hiding this comment.
I don't think that is useful because we often install ign-tools in windows workspaces. I think we want the macros available in all cases, so I don't think we should conditionally find this
src/CMakeLists.txt
Outdated
| @@ -134,6 +134,14 @@ if (BUILD_SDF_TEST) | |||
|
|
|||
| sdf_build_tests(${gtest_sources}) | |||
|
|
|||
| if (IGNITION-TOOLS_BINARY_DIRS) | |||
Some ign_TEST cases were disabled on the sdf10 branch in gazebosim#456, but the merge forward failed to disable the new test cases on the main branch that have been added since sdf10. This disables them all to fix CI. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Following @scpeters suggestion gazebo-tooling/release-tools#365 (comment), the PR disable the run of ign tests on Windows.