Cherry-pick from sdf9 to sdf10 #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…im#245) Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
@chapulina why didn't this get any labels? |
is it because I created the PR from my fork? |
|
added labels manually |
Codecov Report
@@ Coverage Diff @@
## sdf10 #372 +/- ##
==========================================
- Coverage 87.36% 87.32% -0.05%
==========================================
Files 60 60
Lines 9214 9214
==========================================
- Hits 8050 8046 -4
- Misses 1164 1168 +4
Continue to review full report at Codecov.
|
azeey
approved these changes
Sep 9, 2020
Yup, GitHub actions are really annoying with PRs from forks. But just last month they added a new feature that should fix. Here's an issue for tracking this: gazebo-tooling/pr-collection-labeler#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #245, #368, #369, #361 to
sdf10. Use rebase and merge.I've created a branch that merged sdf9 -> sdf10 with resolved conflicts. Compare the diff to confirm that these changes are all that's missing from
sdf10: