[master] Update BitBucket links #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28838f7 to
82a13cb
Compare
82a13cb to
27c863b
Compare
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 86.46% 86.44% -0.03%
==========================================
Files 59 59
Lines 9065 9066 +1
==========================================
- Hits 7838 7837 -1
- Misses 1227 1229 +2
Continue to review full report at Codecov.
|
scpeters
approved these changes
May 8, 2020
… level (#251) SDFormat 9 requires the use of C++17 in its public headers, however it does not correctly expose this requirement in its installed imported targets. In particular, at the moment the requirement of C++17 is only documented via adding the -std=c++17 flag in the `SDFormat_CXX_FLAGS` variable, but this strategy has two problems: * It does not work unless a user explicitly pass this flags to its compilation targets, and this is definitely not obvious if it is not using directly SDFormat, but he is linking sdformat transitively through Gazebo 11. * If a different C++ version is set at the CMake level, it is possible that the `-std=c++17` flag is ignored (it depends what is the order with which the flags are passed to the compiler). For CMake consumers, a better strategy is to use the target_compile_features and explicitly mark that that this library requires the `cxx_std_17` feature, as `PUBLIC` because it also required in the public headers. As the minimum required version of CMake is 3.10, we can use cxx_std_17 as it is available in CMake 3.10, see https://cmake.org/cmake/help/v3.10/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html#prop_gbl:CMAKE_CXX_KNOWN_FEATURES . Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org> [sdf9] Changelog links to BitBucket backup (#240) * [sdf9] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * [sdf8] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * [sdf7] Changelog links to BitBucket backup (#238) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Convert bitbucket links for sdf9 Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Fix link in API documentation Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
27c863b to
e023ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #233, improved the script to also update files other than the changelog.
There are a couple of links to
osrf/gazebowhich won't work until that's migrated.