-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Projector DOM #1277
Add Projector DOM #1277
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1277 +/- ##
==========================================
+ Coverage 87.72% 87.80% +0.08%
==========================================
Files 126 127 +1
Lines 16585 16737 +152
==========================================
+ Hits 14549 14696 +147
- Misses 2036 2041 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor comments
Signed-off-by: Ian Chen <ichen@openrobotics.org>
🎉 New feature
Summary
Add Projector DOM and tests.
I also added a new
<visibility_flags>
field toprojector.sdf
. This allows projections to be made visible only to cameras with matching visibility masks. One common use case is a depth camera with IR projection, in which the projected light / pattern is only visible to IR sensors in the depth camera device.Test it
Run the
INTEGRATION_projector_dom
andUNIT_Projector_TEST
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.