Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Projector DOM #1277

Merged
merged 6 commits into from
May 4, 2023
Merged

Add Projector DOM #1277

merged 6 commits into from
May 4, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 1, 2023

🎉 New feature

Summary

Add Projector DOM and tests.

I also added a new <visibility_flags> field to projector.sdf. This allows projections to be made visible only to cameras with matching visibility masks. One common use case is a depth camera with IR projection, in which the projected light / pattern is only visible to IR sensors in the depth camera device.

Test it

Run the INTEGRATION_projector_dom and UNIT_Projector_TEST

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

iche033 added 2 commits April 27, 2023 23:01
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested review from azeey and scpeters as code owners May 1, 2023 21:23
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels May 1, 2023
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #1277 (c31f3aa) into sdf13 (486740e) will increase coverage by 0.08%.
The diff coverage is 96.71%.

❗ Current head c31f3aa differs from pull request most recent head 927a0c9. Consider uploading reports for the commit 927a0c9 to get more accurate results

@@            Coverage Diff             @@
##            sdf13    #1277      +/-   ##
==========================================
+ Coverage   87.72%   87.80%   +0.08%     
==========================================
  Files         126      127       +1     
  Lines       16585    16737     +152     
==========================================
+ Hits        14549    14696     +147     
- Misses       2036     2041       +5     
Impacted Files Coverage Δ
src/Projector.cc 95.68% <95.68%> (ø)
src/Link.cc 98.18% <100.00%> (+0.18%) ⬆️

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 merged commit 38f6435 into sdf13 May 4, 2023
@iche033 iche033 deleted the projector branch May 4, 2023 23:40
@ahcorde ahcorde mentioned this pull request May 11, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants