-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParticleEmitter: update calls to use sdf::Errors output #1158
Conversation
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
ebbed2d
to
3e9105e
Compare
Codecov Report
@@ Coverage Diff @@
## sdf13 #1158 +/- ##
=======================================
Coverage 87.51% 87.52%
=======================================
Files 126 126
Lines 16422 16431 +9
=======================================
+ Hits 14372 14381 +9
Misses 2050 2050
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test too, LGTM!
Signed-off-by: Marco A. Gutierrez marco@openrobotics.org
🎉 New feature
Work towards #820.
Depends on #1155 and: #1141.
Summary
Adds missing
Errors
structure parameters in a few methods of theParticleEmitter
class.Test it
Using the
ParticleEmitter
class should report all errors throughsdf::Errors
if theerrors
parameter is used, it should print them otherwise.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.