Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticleEmitter: update calls to use sdf::Errors output #1158

Merged
merged 8 commits into from
Mar 29, 2023

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Sep 19, 2022

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Depends on #1155 and: #1141.

Summary

Adds missing Errors structure parameters in a few methods of the ParticleEmitter class.

Test it

Using the ParticleEmitter class should report all errors through sdf::Errors if the errors parameter is used, it should print them otherwise.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Marco A. Gutierrez added 3 commits October 3, 2022 16:40
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@marcoag marcoag changed the base branch from main to sdf13 October 3, 2022 16:40
@marcoag marcoag force-pushed the marcoag/sdf_error_element_particleEmitter branch from ebbed2d to 3e9105e Compare October 3, 2022 16:41
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1158 (6cb23b0) into sdf13 (0f6ca9a) will increase coverage by 0.00%.
The diff coverage is 97.77%.

❗ Current head 6cb23b0 differs from pull request most recent head af91598. Consider uploading reports for the commit af91598 to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1158   +/-   ##
=======================================
  Coverage   87.51%   87.52%           
=======================================
  Files         126      126           
  Lines       16422    16431    +9     
=======================================
+ Hits        14372    14381    +9     
  Misses       2050     2050           
Impacted Files Coverage Δ
src/ParticleEmitter.cc 92.55% <97.77%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Marco A. Gutierrez added 2 commits March 24, 2023 03:26
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@marcoag marcoag requested a review from aaronchongth March 24, 2023 06:25
Copy link
Collaborator

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test too, LGTM!

@marcoag marcoag changed the title ParticleEmitter: update calls to use sdf::Errors parameters ParticleEmitter: update calls to use sdf::Errors output Mar 29, 2023
@marcoag marcoag merged commit 883981d into sdf13 Mar 29, 2023
@marcoag marcoag deleted the marcoag/sdf_error_element_particleEmitter branch March 29, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants