Use more relevant error type

Use POSE_RELATIVE_TO_GRAPH_ERROR instead of ELEMENT_INVALID when a valid PoseRelativeToGraph pointer is not available. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
gazebosim · Jul 24, 2020 · 61af87b · 61af87b
1 parent eb60eca
commit 61af87b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Model.cc b/src/Model.cc
@@ -697,7 +697,7 @@ Errors Model::SetPoseRelativeToGraph(
   auto graph = _graph.lock();
   if (!graph)
   {
-    errors.push_back({ErrorCode::ELEMENT_INVALID,
+    errors.push_back({ErrorCode::POSE_RELATIVE_TO_GRAPH_ERROR,
         "Tried to set PoseRelativeToGraph with invalid pointer."});
     return errors;
   }

diff --git a/src/SemanticPose.cc b/src/SemanticPose.cc
@@ -106,7 +106,7 @@ Errors SemanticPose::Resolve(
   auto graph = this->dataPtr->poseRelativeToGraph.lock();
   if (!graph)
   {
-    errors.push_back({ErrorCode::ELEMENT_INVALID,
+    errors.push_back({ErrorCode::POSE_RELATIVE_TO_GRAPH_ERROR,
         "SemanticPose has invalid pointer to PoseRelativeToGraph."});
     return errors;
   }