Unhide cmake warning when Python3 Development is not found #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of this variable may change, so move the warning to be co-located with the add_subdirectory call. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
this should be ported to gz-math and sdformat as well, since they use the same logic pattern |
caguero
approved these changes
Jan 9, 2025
This was referenced Feb 10, 2025
|
https://github.com/Mergifyio backport gz-transport13 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
* Unify Python3_Development_FOUND checks The value of this variable may change, so move the warning to be co-located with the add_subdirectory call. * Use message(WARNING) Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit f9cd5c5)
8 tasks
This was referenced Feb 10, 2025
scpeters
added a commit
that referenced
this pull request
Feb 14, 2025
* Unify Python3_Development_FOUND checks The value of this variable may change, so move the warning to be co-located with the add_subdirectory call. * Use message(WARNING) Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit f9cd5c5)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Unhides a cmake warning when python bindings will not be built
Summary
A cmake warning should be printed when python bindings will not be built (controlled by the logic around
add_subdirectory(python)), but the warning was in a separate part of the code, allowing the warning to be missed if thePython3_Development_FOUNDvariable changed in between.Since
GZ_BUILD_WARNING("")only generates a cmake warning if invoked beforegz_configure_build, I switched to usemessage(WARNING "")in e464330.Also, the failed Ubuntu Noble CI build is expected because finding python is currently broken for all platforms, but only our Ubuntu Noble CI builds report cmake warnings. I believe finding python should be fixed once gazebosim/gz-msgs#479 is merged and released. I think it would be worth merging this so that our broken state is accurately reflected.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.