Remove deprecations: tock 🕑 #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
ahcorde
approved these changes
Jun 23, 2021
scpeters
reviewed
Jun 25, 2021
| /// \todo Move to src/gui on v6. | ||
| public: explicit IGN_DEPRECATED(5.0) GuiRunner( | ||
| const std::string &_worldName); | ||
| public: explicit GuiRunner(const std::string &_worldName); |
There was a problem hiding this comment.
moving this header file has broken ign-launch:
There was a problem hiding this comment.
hummmmm weird gazebosim/gz-launch#119
82 tasks
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Perform the tock of the tick-tock cycle and remove / move deprecated code.
More context on the deprecation comments.
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸