Wireframe mode #816
Merged
Wireframe mode #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 65.34% 64.92% -0.42%
==========================================
Files 240 240
Lines 17602 17727 +125
==========================================
+ Hits 11502 11510 +8
- Misses 6100 6217 +117
Continue to review full report at Codecov.
|
nkoenig
reviewed
May 13, 2021
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
ahcorde
approved these changes
May 14, 2021
src/gui/plugins/scene3d/Scene3D.cc
Outdated
| } | ||
| } | ||
|
|
||
|
|
|
@atharva-18 it seems that you were able to make it work with nested models. Do you mind to have a look to this issue? #767 . Collision visualization is not working right now with nested model. |
nkoenig
approved these changes
May 17, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
View models and links as wireframes, similar to Gazebo Classic.
Nested model
Test it
Test it by running
ign gazebo -v 4 examples/worlds/nested_model.sdfChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸