Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for EntityComponentManager::EachNew #795

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Apr 29, 2021

Signed-off-by: Ashton Larkin ashton@openrobotics.org

Summary

I've updated the documentation for EntityComponentManager::EachNew to reflect how this method should be used with system plugins. There appeared to be a typo in the existing documentation, which could cause confusion to users.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@adlarkin adlarkin requested review from azeey and chapulina April 29, 2021 17:42
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 29, 2021
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin adlarkin merged commit 4ee7d57 into ign-gazebo3 Apr 29, 2021
@adlarkin adlarkin deleted the adlarkin/eachNew_doc branch April 29, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants