Deprecate TmpIface: it's leftover from prototyping #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #654 +/- ##
==========================================
+ Coverage 77.13% 77.20% +0.06%
==========================================
Files 215 215
Lines 12074 12071 -3
==========================================
+ Hits 9313 9319 +6
+ Misses 2761 2752 -9
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This file was never meant to be installed. In fact, it should have been deleted back before we released Acropolis:
https://github.com/ignitionrobotics/ign-gazebo/blob/bd261d5c140fa4c31a6df8702a305d400e3e1654/include/ignition/gazebo/gui/TmpIface.hh#L38
Better late than never 😇
I felt the urge to just remove it, but we never know if some code is instantiating it by mistake... So this kicks off the tick-tock cycle (deprecate on v5, remove on v6). It's been there for 4 versions, one more won't hurt.
I also removed all the disabled code for loading a new world or a world from a file. We can revive it when addressing #94.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge