Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded if statement #432

Merged
merged 19 commits into from
Nov 18, 2020
Merged

Remove unneeded if statement #432

Changes from 16 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3904c21
draft
Oct 14, 2020
c526f78
vector to map
Oct 15, 2020
3976133
Finish conversion
Oct 15, 2020
67a3351
Finish implementation of optimization
Oct 16, 2020
93cdb81
Merge branch 'ign-gazebo3' into jshep1/scenebroadcaster_optimizations
Oct 16, 2020
b5e86b6
Clean up
Oct 16, 2020
31812ff
Clean up again
Oct 16, 2020
b74426d
Another pass
Oct 16, 2020
5adc0c6
Another one
Oct 16, 2020
8eda00c
Merge branch 'ign-gazebo3' into jshep1/scenebroadcaster_optimizations
Oct 20, 2020
afee595
requested fixes
Oct 21, 2020
b521bed
Merge branch 'jshep1/scenebroadcaster_optimizations' of https://githu…
Oct 21, 2020
95cf961
Merge branch 'ign-gazebo3' into jshep1/scenebroadcaster_optimizations
Oct 23, 2020
e7acbc8
Merge branch 'ign-gazebo3' into jshep1/scenebroadcaster_optimizations
Oct 27, 2020
755b88d
remove unneeded if statement
Oct 29, 2020
f96ef78
Merge branch 'ign-gazebo3' into jshep1/scenebroadcaster_optimizations2
chapulina Nov 9, 2020
6f4270d
Merge branch 'ign-gazebo3' into jshep1/scenebroadcaster_optimizations2
chapulina Nov 12, 2020
827fd47
Merge branch 'ign-gazebo3' into jshep1/scenebroadcaster_optimizations2
chapulina Nov 16, 2020
6becd81
Merge branch 'ign-gazebo3' into jshep1/scenebroadcaster_optimizations2
Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/EntityComponentManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,15 +851,6 @@ void EntityComponentManager::AddEntityToMessage(msgs::SerializedStateMap &_msg,

// TODO(anyone) Set component being removed once we have a way to queue it
}

// Remove the entity from the message if a component for the entity was
// not modified or added. This will allow the state message to shrink.
if (entIter == _msg.mutable_entities()->end() &&
(entIter = _msg.mutable_entities()->find(_entity)) !=
_msg.mutable_entities()->end())
{
_msg.mutable_entities()->erase(entIter);
}
}

//////////////////////////////////////////////////
Expand Down