Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated source build instructions for ign-gazebo4 #404

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

adlarkin
Copy link
Contributor

I've updated the ign-gazebo4 README to have the same source build approach as ign-gazebo3 (#395). The main change is replacing the manual list of dependencies with the packages listed in .github/ci/.

Signed-off-by: Ashton Larkin ashton@openrobotics.org

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin adlarkin requested a review from chapulina October 12, 2020 20:28
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Oct 12, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of places still say ign-gazebo2

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin
Copy link
Contributor Author

A couple of places still say ign-gazebo2

Whoops, sorry about that! I think ign-gazebo2 was still in my mind since I just updated that branch. Everything should be fixed now.

@chapulina chapulina merged commit 53f7bdb into ign-gazebo4 Oct 12, 2020
@chapulina chapulina deleted the adlarkin/source_build_ign_gazebo4 branch October 12, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants