Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed <uri>s in sdf files #389

Closed
wants to merge 1 commit into from
Closed

Fixed <uri>s in sdf files #389

wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 29, 2020

I'm getting some errors because of theses spaces

Signed-off-by: Alejandro Hernández ahcorde@gmail.com

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 29, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files         200      200           
  Lines       10709    10709           
=======================================
  Hits         8267     8267           
  Misses       2442     2442           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e179981...d22f880. Read the comment docs.

@chapulina
Copy link
Contributor

@ahcorde , how did you install SDFormat? This PR should have fixed this: gazebosim/sdformat#359

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 29, 2020

yes, I have this PR in. I will check it again.

@chapulina
Copy link
Contributor

@ahcorde , I don't have problems with these URIs using pre-release debs on Bionic or Focal.

@scpeters
Copy link
Member

try brew outdated to see if you have the latest prerelease of sdformat10

@scpeters
Copy link
Member

yeah, I believe this PR shouldn't be necessary due to gazebosim/sdformat#359

@chapulina
Copy link
Contributor

@ahcorde , I'll close this for now, but let us know if the problem reappears for you.

@chapulina chapulina closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants