add 10k actors and generalize actors pose in erb #336
Conversation
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
| @@ -138,13 +142,26 @@ | |||
| </include> | |||
|
|
|||
| <% | |||
| # number of population | |||
There was a problem hiding this comment.
The dude on line 141 seems a bit lost in the crowd, is he needed?
There was a problem hiding this comment.
Do you mean this # number of population line? I think you are looking at the old file? This is the new change equivalent to that line https://github.com/ignitionrobotics/ign-gazebo/pull/336/files#diff-b1617932cd58db140bca53385d0da9bcR145
There was a problem hiding this comment.
Oh sorry, I meant the included actor around line 141 of the new file:
<include>
<uri>https://fuel.ignitionrobotics.org/1.0/Mingfei/models/actor</uri>
</include>
There was a problem hiding this comment.
I remember the lonely actor used to be able to walk around others without bumping into anyone :)
There was a problem hiding this comment.
Ooo that's what it was. I was wondering why there's always an extra actor different from others. Yeah I'll remove it.
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
|
Failed test cases on osx and ubuntu are not introduced by this PR. Merging... |
* add more descriptive sdf names and generalize actors erb Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com> Signed-off-by: Guillaume Doisy <guillaume.doisy@wyca.fr>
minor tweaks to add more descriptive actors and shapes sdf file names, and generalize actors pose in erb file