Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed left menu events #218

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Fixed left menu events #218

merged 3 commits into from
Jun 23, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 22, 2020

Same idea as this other PR gazebosim/gz-gui#85

The left menu is not working this should fix the isse

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added bug Something isn't working 🔮 dome Ignition Dome labels Jun 22, 2020
@ahcorde ahcorde requested a review from chapulina June 22, 2020 20:28
@ahcorde ahcorde self-assigned this Jun 22, 2020
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #218 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   65.77%   65.77%           
=======================================
  Files         128      128           
  Lines        6305     6305           
=======================================
  Hits         4147     4147           
  Misses       2158     2158           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8061d0...6a195fa. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Same nitpick as in the ign-gui plugin, let's follow the camelCase pattern for QML properties.

ahcorde added 2 commits June 23, 2020 08:42
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina June 23, 2020 06:46
@chapulina chapulina merged commit 4e4f029 into master Jun 23, 2020
@chapulina chapulina deleted the ahcorde/fix/left_menu branch June 23, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants