Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reset button from being cropped in world control gui plugin #2155

Closed
wants to merge 1 commit into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 20, 2023

🦟 Bug fix

Summary

The reset button is cropped in many of the example worlds that have the world control gui plugin specified.

cropped_reset

Removing the width property reveals the button, which matches what's done in the default gui.config file

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 20, 2023
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to backport this one #2151?

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2155 (cf4ad37) into gz-sim7 (9d79b62) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head cf4ad37 differs from pull request most recent head ded14ae. Consider uploading reports for the commit ded14ae to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2155      +/-   ##
===========================================
+ Coverage    65.01%   65.02%   +0.01%     
===========================================
  Files          356      356              
  Lines        28932    28932              
===========================================
+ Hits         18809    18814       +5     
+ Misses       10123    10118       -5     

see 2 files with indirect coverage changes

@iche033
Copy link
Contributor Author

iche033 commented Sep 20, 2023

Would it be better to backport this one #2151?

oh yes, I missed that one. I'll close this and cherry pick instead.

@iche033 iche033 closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants