Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voldivh/model command output update #2138

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Sep 12, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#324

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Voldivh Voldivh changed the base branch from gz-sim7 to gz-sim8 September 12, 2023 16:39
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 12, 2023
@ahcorde
Copy link
Contributor

ahcorde commented Sep 12, 2023

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@Voldivh Voldivh force-pushed the voldivh/model_command_output_update branch from 069aa8a to 02c0a56 Compare September 12, 2023 17:03
@Voldivh Voldivh requested a review from ahcorde September 12, 2023 17:24
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #2138 (f580cd1) into gz-sim8 (4135cd1) will increase coverage by 0.01%.
Report is 2 commits behind head on gz-sim8.
The diff coverage is n/a.

❗ Current head f580cd1 differs from pull request most recent head 02c0a56. Consider uploading reports for the commit 02c0a56 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2138      +/-   ##
===========================================
+ Coverage    65.45%   65.47%   +0.01%     
===========================================
  Files          323      323              
  Lines        30704    30704              
===========================================
+ Hits         20096    20102       +6     
+ Misses       10608    10602       -6     

see 1 file with indirect coverage changes

@Voldivh Voldivh merged commit e9fa7d4 into gz-sim8 Sep 12, 2023
@Voldivh Voldivh deleted the voldivh/model_command_output_update branch September 12, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-sim: Model Command
2 participants