Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies the definition of hydrodynamics plugin #2137

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Sep 12, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#299

Summary

modifies the names of the absolute variables in the plugin definition.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@Voldivh Voldivh requested a review from mjcarroll as a code owner September 12, 2023 16:08
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 12, 2023
@Voldivh Voldivh merged commit f9f9897 into gz-sim8 Sep 12, 2023
@Voldivh Voldivh deleted the voldivh/lrauv_control_demo_plugin_definition branch September 12, 2023 17:23
@azeey
Copy link
Contributor

azeey commented Sep 15, 2023

This was merged with "merge commit". Let's remember to use "Squash-Merge" next time (per the note to maintainers in the PR description).

@Voldivh
Copy link
Contributor Author

Voldivh commented Sep 15, 2023

This was merged with "merge commit". Let's remember to use "Squash-Merge" next time (per the note to maintainers in the PR description).

Sure thing, so sorry about it. I forgot to change it due to it being only 1 commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants