Prevent crash when viewing heightmap collision #2097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
If you try to view heightmap collisions (View > Collisions), the GUI crashes. This PR prints out a warning to say that it's not currently supported instead of just crashing.
The problem is that the heightmaps shaders currently expect texture maps exist (it does not work with just simple diffuse colors). If they are not available, the shaders fail to compile at runtime and cause the GUI to crash.
Note: I accidentally pushed to
gz-sim7
and created a reverse commit (3f80b37) to undo the changes 🙇.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.