Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TopicInfo deprecation warnings in Harmonic #1922

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 8, 2023

🦟 Bug fix

Summary

Updated code to use the new TopicInfo function introduced in gazebosim/gz-transport#384. The existing one is deprecated.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from mjcarroll as a code owner March 8, 2023 23:32
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1922 (f3d4074) into main (2d19f93) will increase coverage by 0.20%.
The diff coverage is 72.22%.

❗ Current head f3d4074 differs from pull request most recent head d828658. Consider uploading reports for the commit d828658 to get more accurate results

@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
+ Coverage   64.26%   64.47%   +0.20%     
==========================================
  Files         340      341       +1     
  Lines       26962    27143     +181     
==========================================
+ Hits        17328    17500     +172     
- Misses       9634     9643       +9     
Impacted Files Coverage Δ
include/gz/sim/ServerConfig.hh 100.00% <ø> (ø)
include/gz/sim/SystemLoader.hh 100.00% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/DetachableJoint.hh 100.00% <ø> (ø)
...nclude/gz/sim/components/ExternalWorldWrenchCmd.hh 100.00% <ø> (ø)
include/gz/sim/components/LevelBuffer.hh 100.00% <ø> (ø)
include/gz/sim/components/LevelEntityNames.hh 100.00% <ø> (ø)
include/gz/sim/components/PerformerAffinity.hh 100.00% <ø> (ø)
include/gz/sim/components/PerformerLevels.hh 100.00% <ø> (ø)
include/gz/sim/rendering/RenderUtil.hh 100.00% <ø> (ø)
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 merged commit d839caf into main Mar 10, 2023
@iche033 iche033 deleted the topicinfo_warnings branch March 10, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants