Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Windows to green on gz-sim7 #1917

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Get Windows to green on gz-sim7 #1917

merged 4 commits into from
Mar 9, 2023

Conversation

mjcarroll
Copy link
Contributor

Follow up to #1911

@mjcarroll
Get Windows to green on gz-sim7
03155f2 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #1917 (d96241c) into gz-sim7 (753ec8d) will not change coverage.
The diff coverage is n/a.

❗ Current head d96241c differs from pull request most recent head bcf4159. Consider uploading reports for the commit bcf4159 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #1917   +/-   ##
========================================
  Coverage    64.54%   64.54%           
========================================
  Files          347      347           
  Lines        27777    27777           
========================================
  Hits         17930    17930           
  Misses        9847     9847

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

azeey
azeey reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restarted the windows build.

@mjcarroll
Check variable result
0e1dbb4 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll force-pushed the mjcarroll/greener7 branch from 9c914ba to 0e1dbb4 Compare March 6, 2023 20:36
@azeey azeey mentioned this pull request Mar 7, 2023
Merged
9 tasks
@mjcarroll mjcarroll marked this pull request as ready for review March 8, 2023 13:39
mjcarroll added 2 commits March 8, 2023 13:42
@mjcarroll
Merge branch 'gz-sim7' into mjcarroll/greener7
9925f5e
@mjcarroll
Use int64 rather than long
bcf4159 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
azeey
azeey approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe most, if not all, of the CI failures are due to a Fuel server issue.

@mjcarroll mjcarroll merged commit 206def3 into gz-sim7 Mar 9, 2023
@mjcarroll mjcarroll deleted the mjcarroll/greener7 branch March 9, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @azeey