Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase thread sleep delay #1902

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

Crola1702
Copy link
Contributor

🦟 Bug fix

Fixes #1886

Summary

Check #1886 (comment) and below

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 requested a review from mjcarroll as a code owner February 16, 2023 21:42
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1902 (6305718) into gz-sim7 (4a19909) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           gz-sim7    #1902      +/-   ##
===========================================
- Coverage    64.63%   64.61%   -0.03%     
===========================================
  Files          347      347              
  Lines        27720    27720              
===========================================
- Hits         17917    17911       -6     
- Misses        9803     9809       +6     
Impacted Files Coverage Δ
src/systems/thruster/Thruster.cc 83.62% <0.00%> (-2.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey merged commit c03c432 into gz-sim7 Feb 17, 2023
@azeey azeey deleted the Crola1702/increase-gui-test-sleep branch February 17, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

👨‍🌾 Flaky test: UNIT_Gui_clean_exit_TEST in gz-sim7 focal
2 participants