Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msgs, transport, and fuel-tools version in Harmonic #1892

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 11, 2023

🎉 New feature

Summary

Bumping to use the new msgs, transport, and fuel-tools versions in Harmonic: msgs10, transport13, fuel-tools9

Depends on:
gazebosim/gz-fuel-tools#326
gazebo-tooling/release-tools#876

Related PR: gazebo-release/gz-sim8-release#1

Part of gazebo-tooling/release-tools#878

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Mar 3, 2023

@osrf-jenkins run tests please

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1892 (d08dd17) into main (e7d8f5e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
+ Coverage   64.48%   64.50%   +0.01%     
==========================================
  Files         342      342              
  Lines       27141    27141              
==========================================
+ Hits        17501    17506       +5     
+ Misses       9640     9635       -5     
Impacted Files Coverage Δ
src/Util.cc 91.97% <0.00%> (-0.31%) ⬇️
src/SimulationRunner.cc 92.27% <0.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 marked this pull request as ready for review March 4, 2023 01:13
@iche033
Copy link
Contributor Author

iche033 commented Mar 4, 2023

This PR is ready for review. Harmonic CIs are now working.

@nkoenig
Copy link
Contributor

nkoenig commented Mar 8, 2023

@osrf-jenkins run tests please.

@iche033 iche033 merged commit 7fc5428 into main Mar 8, 2023
@iche033 iche033 deleted the bump_msgs_transport_fuel-tools branch March 8, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants