Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add P gain value for Ackermann steering. #1873

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented Jan 28, 2023

🦟 Bug fix

Fixes #1872

Summary

Adds P gain for ackermann steering when:

 <steering_only>true</steering_only>

Set with:

<steer_p_gain>your_value</steer_p_gain>

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 28, 2023
Adds P gain for ackermann steering when:
<steering_only>true</steering_only>
Set with:
<steer_p_gain>your_value</steer_p_gain>

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
@bperseghetti bperseghetti force-pushed the pr-ackermann-steer-pgain branch from fdd434e to ba980bc Compare January 28, 2023 05:26
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #1873 (ba980bc) into gz-sim7 (af73ebe) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           gz-sim7    #1873      +/-   ##
===========================================
+ Coverage    64.64%   64.67%   +0.02%     
===========================================
  Files          343      343              
  Lines        27542    27544       +2     
===========================================
+ Hits         17805    17813       +8     
+ Misses        9737     9731       -6     
Impacted Files Coverage Δ
...rc/systems/ackermann_steering/AckermannSteering.hh 100.00% <ø> (ø)
...rc/systems/ackermann_steering/AckermannSteering.cc 80.54% <50.00%> (+0.09%) ⬆️
src/SimulationRunner.cc 91.20% <0.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ackermann steering is not responsive.
2 participants