Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SdfGenerator unit test #1853

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix SdfGenerator unit test #1853

merged 1 commit into from
Jan 5, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 5, 2023

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Fixes #1852

Summary

The backpack model was updated in December. I believe that's when the test started failing. This is fixed in main branch

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from mjcarroll as a code owner January 5, 2023 18:47
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #1853 (e45e009) into gz-sim7 (90eb788) will increase coverage by 0.46%.
The diff coverage is 83.53%.

❗ Current head e45e009 differs from pull request most recent head 3a600e6. Consider uploading reports for the commit 3a600e6 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #1853      +/-   ##
===========================================
+ Coverage    64.19%   64.66%   +0.46%     
===========================================
  Files          336      342       +6     
  Lines        26916    27350     +434     
===========================================
+ Hits         17278    17685     +407     
- Misses        9638     9665      +27     
Impacted Files Coverage Δ
include/gz/sim/SystemLoader.hh 100.00% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/DetachableJoint.hh 100.00% <ø> (ø)
...nclude/gz/sim/components/ExternalWorldWrenchCmd.hh 100.00% <ø> (ø)
include/gz/sim/components/LevelBuffer.hh 100.00% <ø> (ø)
include/gz/sim/components/LevelEntityNames.hh 100.00% <ø> (ø)
include/gz/sim/components/PerformerAffinity.hh 100.00% <ø> (ø)
include/gz/sim/components/PerformerLevels.hh 100.00% <ø> (ø)
src/Barrier.cc 100.00% <ø> (ø)
src/TestFixture.cc 100.00% <ø> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 merged commit f49fb5a into gz-sim7 Jan 5, 2023
@iche033 iche033 deleted the fix_sdfgenerator_test branch January 5, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

SdfGenerator_TEST test regression because of different uris
2 participants