-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example controller for LRAUV #1822
Conversation
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1822 +/- ##
===========================================
- Coverage 64.52% 64.44% -0.08%
===========================================
Files 341 341
Lines 27185 28826 +1641
===========================================
+ Hits 17540 18577 +1037
- Misses 9645 10249 +604
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README is empty. Did you forget to commit it?
Sorry about that, still working on the controller. I meant to keep this as a draft. |
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
c1eb3cf
to
0196c18
Compare
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityapande-1995 this looks great. Left a few comments. Will test next.
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
@adityapande-1995 we should check failing CI jobs. |
@osrf-jenkins retest this please |
@adityapande-1995 not sure what the policy is, but I see the same as you: it's We should be good to merge this patch. |
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Summary
This PR adds a simple PID based controller for LRAUVs, specifically a PI controller for speed, and P for yaw and pitch angles.
The target state is the linear speed, yaw and pitch angle of the vehicle.
Test it
The required world file is
gz-sim/examples/worlds/lrauv_control_demo.sdf
. Run that file in a terminal :and in a separate terminal, source the Gazebo Garden workspace and run :
This would make the vehicle maintain a speed of 0.5 m/s, yaw angle of 0.78 rad (~ 45 deg) and pitch angle of 0.147 rad (~10 deg).
TODO
Screenshot
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.