Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused attributes in view_angle plugin #1809

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Nov 23, 2022

Signed-off-by: Alejandro Hernández Cordero ahcorde@gmail.com

🦟 Bug fix

Summary

Removed unused attributes in view_angle plugin

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll as a code owner November 23, 2022 14:33
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 23, 2022
@ahcorde ahcorde self-assigned this Nov 23, 2022
@ahcorde ahcorde merged commit bb85aa2 into gz-sim7 Nov 23, 2022
@ahcorde ahcorde deleted the ahcorde/7/clean_view_angle branch November 23, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants