Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nameFilter of saveDialog from "World files" to "SDF files" #1774

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Nov 1, 2022

🦟 Bug fix

Summary

In the world save dialog, the file extension does not show up. By having "World files", many people may misinterpret this to be a .world file (like I did).

image

By having SDF files, this would at least suggest usage of .sdf file. Without the correct extension, the OK button stays greyed out:

image

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ijnek ijnek requested a review from mjcarroll as a code owner November 1, 2022 03:16
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 1, 2022
@ijnek ijnek changed the title Change name of nameFilter of saveDialog to "SDF files" Change nameFilter of saveDialog from "World files"to "SDF files" Nov 1, 2022
@ijnek ijnek changed the title Change nameFilter of saveDialog from "World files"to "SDF files" Change nameFilter of saveDialog from "World files" to "SDF files" Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1774 (cf10d76) into gz-sim7 (6a8594b) will increase coverage by 0.06%.
The diff coverage is 72.11%.

@@             Coverage Diff             @@
##           gz-sim7    #1774      +/-   ##
===========================================
+ Coverage    64.16%   64.22%   +0.06%     
===========================================
  Files          335      336       +1     
  Lines        26508    26600      +92     
===========================================
+ Hits         17008    17083      +75     
- Misses        9500     9517      +17     
Impacted Files Coverage Δ
src/SystemLoader.cc 59.50% <44.44%> (+1.54%) ⬆️
src/systems/acoustic_comms/AcousticComms.cc 93.22% <93.22%> (ø)
src/Util.cc 93.39% <0.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now that we don't use .world files, I think it makes sense to say "SDF files".

@ijnek
Copy link
Contributor Author

ijnek commented Nov 5, 2022

Not sure if CI failure is related.

@ahcorde ahcorde merged commit 0d40d50 into gazebosim:gz-sim7 Nov 7, 2022
@ijnek ijnek deleted the patch-1 branch November 8, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants