Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock step video recording is broken, disabling #1707

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 14, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🦟 Bug fix

Lock step video recording is broken. Attempting to record a video with lock step enabled causes the GUI to deadlock.
Here is the issue: #1706

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig added the tutorial-party Use to indicate a PR is for a tutorial party, which is part of the Gazebo release process. label Sep 14, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1707 (1769c24) into gz-sim7 (22b7852) will not change coverage.
The diff coverage is n/a.

❗ Current head 1769c24 differs from pull request most recent head 7d276f0. Consider uploading reports for the commit 7d276f0 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #1707   +/-   ##
========================================
  Coverage    63.90%   63.90%           
========================================
  Files          334      334           
  Lines        26344    26344           
========================================
  Hits         16836    16836           
  Misses        9508     9508           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nkoenig nkoenig merged commit a94ca54 into gz-sim7 Sep 19, 2022
@nkoenig nkoenig deleted the lock_step_broken_disabling branch September 19, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden tutorial-party Use to indicate a PR is for a tutorial party, which is part of the Gazebo release process.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants