Remove plotIcon in Physics.qml for Component Inspector #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youhy <haoyuan2019@outlook.com>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1658 +/- ##
============================================
Coverage 77.98% 77.98%
============================================
Files 255 255
Lines 15041 15041
============================================
Hits 11729 11729
Misses 3312 3312 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nkoenig
approved these changes
Oct 13, 2022
|
Friendly reminder, we'll need to make sure these changes don't get forward ported |
nkoenig
added a commit
that referenced
this pull request
Nov 3, 2022
* 🎈 3.14.0~pre1 (#1650) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Remove redundant namespace references (#1635) Signed-off-by: methylDragon <methylDragon@gmail.com> * 🎈 3.14.0 (#1657) Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> * readd namespaces for Q_ARGS (#1670) * Remove actors from screen when they are supposed to (#1699) # 🦟 Bug fix Supercedes #1697. Note: When forward porting we will have to update the hashmaps to erase the new hashmaps created. Fixes #<NUMBER> ## Summary Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils. ## Before  ## After  ## Notes: Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all. Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes? Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Update examples to use gazebosim.org Signed-off-by: Nate Koenig <nate@openrobotics.org> * Citadel: Removed warnings (#1753) Signed-off-by: ahcorde <ahcorde@gmail.com> * Added collection name to About Dialog (#1756) Signed-off-by: ahcorde <ahcorde@gmail.com> * Convert ignitionrobotics to gazebosim in tests directory (#1757) * Convert ignitionrobotics to gaazebosim in tests directory Signed-off-by: Nate Koenig <nate@openrobotics.org> * fix gz-gazebo Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Convert ignitionrobotics to gazebosim in sources and includes (#1758) Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Convert ignitionrobotics to gazebosim in tutorials (#1759) Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Final update of ignitionrobotics to gazebosim for citadel (#1760) Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * remove PlotIcon (#1658) Signed-off-by: youhy <haoyuan2019@outlook.com> Signed-off-by: youhy <haoyuan2019@outlook.com> * Fix UNIT_ign_TEST Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: methylDragon <methylDragon@gmail.com> Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: youhy <haoyuan2019@outlook.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Arjo Chakravarty <arjo@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: AzulRadio <50132891+AzulRadio@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youhy haoyuan2019@outlook.com
Bug fix
Summary
This PR should not be ported forward.
Remove plotIcon in
Physics.qmlbecause plotting is not a feature for citadel and there is a warning about cannot findplottable_icon.svgeverytime Gazebo Citadel is launched with msg print on.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.