Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace plotIcon in ComponentInspector with GzPlotIcon #1638

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

AzulRadio
Copy link
Contributor

New feature

Summary

As title. The behavior should be exactly the same as before. Replace for Light.qml Physics.qml and SphericalCoordinates.qml.

All replacements for plotIcon in component Inspector should go into this PR.

Test it

For SphericalCoordinates testing:

ign gazebo . -v 4 ./spherical_coordinates.sdf --render-engine ogre

For Light testing:

ign gazebo . -v 4 ./lights.sdf --render-engine ogre

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio added GUI Gazebo's graphical interface (not pure Ignition GUI) needs upstream release Blocked by a release of an upstream library OOBE 📦✨ Out-of-box experience labels Aug 9, 2022
@AzulRadio AzulRadio requested a review from chapulina as a code owner August 9, 2022 16:53
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1638 (739b801) into ign-gazebo6 (8c9489d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-gazebo6    #1638      +/-   ##
===============================================
- Coverage        64.40%   64.38%   -0.03%     
===============================================
  Files              320      320              
  Lines            25892    25892              
===============================================
- Hits             16677    16671       -6     
- Misses            9215     9221       +6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 89.98% <0.00%> (-0.96%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina requested a review from jennuine August 9, 2022 20:15
@jennuine jennuine removed the needs upstream release Blocked by a release of an upstream library label Aug 12, 2022
@AzulRadio AzulRadio merged commit b5dbd52 into ign-gazebo6 Aug 12, 2022
@AzulRadio AzulRadio deleted the azulradio/componentinspector_gzploticon branch August 12, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants